[vlc-devel] [RFC] SDI input module

Jean-Baptiste Kempf jb at videolan.org
Mon Apr 26 08:42:03 CEST 2010

On Mon, Apr 26, 2010 at 08:10:59AM +0200, Rémi Duraffort wrote :
> Hello,
> only some cosmetics remarks.
All modified.

> > +#include "sdi.h"
> <sdi.h> or the sdi.h file is missing in the patch ?
Seriously, I am not sure, here.

The sdi.h file is provided by the master sdi driver. Maybe a <sdi.h>
would be better then... Maybe we should ship it.

> > +    snprintf( psz_file, sizeof(psz_file), psz_fmt, i_link );
> > +    psz_file[sizeof(psz_file) - 1] = '\0';
> AFAIR, snprintf allways add a '\0' at the end of the string
The man isn't that clear about it, but it seem to imply it, yes.

Best Regards,

Jean-Baptiste Kempf

More information about the vlc-devel mailing list