[vlc-devel] [PATCH 1/3] Qt: Run mainloop on the main thread on OSX

Juho Vähä-Herttua juhovh at iki.fi
Mon Aug 2 00:09:02 CEST 2010

On 1.8.2010, at 22.37, Juho Vähä-Herttua wrote:
> On 31.7.2010, at 22.30, Rémi Denis-Courmont wrote:
>> Merged, thanks.
> I'd just like to let you know that commit 4d636fa3a74924691b0b hangs the interface on Mac after quitting. I haven't yet figured out why, since it clearly shouldn't.

The change you made prevents vlc_kill from being called, because libvlc_SetExitHandler of qt4.cpp or alternatively libvlc_InternalWait of interface.c overrides the exit handler. Therefore the SIGTERM is never sent and it stucks forever in the sigwait. I'd recommend just reverting the patch, since set_exit_handler is clearly in its original place for a reason, and I don't see what this change is actually trying to fix. Other fixes are of course also welcome.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4215 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100802/b1f55d0d/attachment.bin>

More information about the vlc-devel mailing list