[vlc-devel] [PATCH] DVB-S scanning support

[David Kaplan]

On Tue, Aug 3, 2010 at 12:11 PM, Rémi Duraffort <ivoire at videolan.org> wrote:

> > > > +    if( p_scan->parameter.type == SCAN_DVB_S )
> > > > +        /* set satellite config file path */
> > > > +        strncpy( p_scan->parameter.sat_info.psz_name,
> > > > +                 var_GetString( p_access, "dvb-satellite" ),
> > > > +                 sizeof(p_scan->parameter.sat_info.psz_name) );
> > >
> > > Memory leak.
> > >
> >
> > Where's it leaking? .psz_name is allocated on the heap.
> var_GetString allocate the memory needed for the string (strdup) so you
> are leaking here.
>

Ahh ok. didn't realise it did a strdup (just thought it passed a ptr to the
string).
Will fix - thanks! :)


>
> best regards
>
> --
> Rémi Duraffort | ivoire
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>



-- 
http://blog.2of1.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100803/9da5d41e/attachment.html>