[vlc-devel] [PATCH] Direct3D shader support (HLSL)

Sasha Koruga skoruga at gmail.com
Sat Aug 14 08:12:35 CEST 2010

I realized the alignment issue (which were all due to me using tabs
instead of spaces), and hence the "untabify" patches; those patches
should have fixed all alignment issues. Are there other alignment
issues you're referring to?

I'll run some benchmarks and let you know soon.

I inserted the casting because it removed a warning, which I believe
is a good reason for casting.


> On Fri, Aug 13, 2010 at 11:01 PM, xxcv <xxcv07 at gmail.com> wrote:
>> Hi,
>> On 14/08/2010 3:34 PM, Sasha Koruga wrote:
>>> Hello,
>>> I hope I am doing this right! I git cloned the latest vlc version
>>> today, and added the changes I've been working on. The patches are
>>> attached to this email.
>>> Here's the feature list:
>>> -High Level Shader Language (HLSL) support for the Direct3D module
>>> (default for Windows Vista and Windows 7)
>>> -Added GUI to allow real-time selection of shaders (can change
>>> midstream, during pause, etc, with no delay)
>>> -Good fallback support (if video card does not support shaders,
>>> shaders will automatically be disabled)
>>> -SHADER: Grayscale - Plays the video in grayscale
>>> -SHADER: Invert Colors - Plays the video with inverted colors
>>> -SHADER: 16-235 ->  0-255 - linearly scales color space from 16-235 to
>>> 0-255  (e.g 0-16 will all be 0)
>>> -SHADER: Red Detect 0-15&  236-255 - Replaces colors which are between
>>> 0-15&  236-255 with red, in order to see how much the video will
>>> benefit from the above shader
>>> -SHADER: bt601 ->  bt709 - Makes the video output in BT.709 as oppose
>>> to BT.601 (for high-def video)
>>> -SHADER: Gamma Correction (1.8) - Gamma corrects the video with value 1.8
>>> -SHADER: Gamma Correction (2.2) - Gamma corrects the video with value 2.2
>>> -SHADER: Gamma Correction (BT.709) - Gamma corrects the video
>>> according to the BT.709 standards
>>> Work in progress: YUV->RGB&  other color space conversion shaders,
>>> OpenGL support&  shaders, sharpening shader(s), and scaling shader(s)
>>> Best Regards,
>>> Sasha Koruga
>> I looked through your patches and I found the obviously needed alignment
>> missing which made the code a little harder to read, as well as the some of
>> the lines are over 80 characters long.
>> Can you please change it for better reading !
>> Do you know if there are any impact at all in d3d speed after shader support
>> patch ?
>> Thank you,
>> Best Regards,
>> --
>> My VLC, My Way, My Style~

More information about the vlc-devel mailing list