[vlc-devel] [PATCH] Direct3D shader support (HLSL)
jb at videolan.org
Sat Aug 14 13:06:04 CEST 2010
On Fri, Aug 13, 2010 at 10:34:44PM -0700, Sasha Koruga wrote :
> I hope I am doing this right! I git cloned the latest vlc version
> today, and added the changes I've been working on. The patches are
> attached to this email.
Thanks a lot for your work. This is very needed for VLC.
About your patches:
- please do NOT send .zip on this mailing list. This makes it very hard
- please learn to squash your patches, so you only submit complete
patches. For example, all your untabify patches shouldn't even exist.
To do that correctly, use git rebase -i origin/master
This will help to reorder, squash, etc... your patches.
1 and 2 should be merged, for example
- please make your patches with a better title, for example 3 and 4
have the same title, but are not the same.
- please separate, when possible cosmetics from actual code changes.
Shouldn't the shaders be in special files?
If if (!sys->hd3d9x_dll), shouldn't you delete the shader-effect
+33 672 704 734
More information about the vlc-devel