[vlc-devel] [PATCH]Remove automatic handling of volume and mute keys in QT4

[Rémi Denis-Courmont]

Le dimanche 15 août 2010 19:10:09 Kaarlo Räihä, vous avez écrit :
> With late VLC versions (using QT4 interface) the mute and volume keyboard
> keys are processed twice. Once by VLC which then sends same command
> forward. So pressing volume up key once while VLC is active will increase
> both VLC and Windows mixer volume levels.
> 
> Correct thing would be allow user to choose what they want, but since
> someone in forums provided patch for this, I think it is just easier to
> return old behavior back. (and yes, people have complained about this)
> http://forum.videolan.org/viewtopic.php?f=14&t=79258#p267960

Hmm, not really. VLC should automatically handle keys which are not grabbed by 
another application, and *only* those. Second guessing that the volume keys 
should be dealt with and other media keys not is ugly and silly in my opinion.

Also the VLC Qt4 interface should pass those keys to the hotkey interface 
instead of handling them directly, while the hotkey interface should be fixed 
to handle media keys statically. I don't see why only the Qt4 interface should 
support media keys!

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis