[vlc-devel] [PATCH] removed some trivial warnings

Toralf Niebuhr vlc at niebuhrt.de
Wed Aug 25 08:00:01 CEST 2010


Am 25.08.2010 um 05:58 schrieb Rémi Denis-Courmont:

> ----- Message d'origine -----
>> Compiling this with "g++ -o main test.cpp -O3 -Wall" results in no warnings.
> 
> That it does not show with you compiler,  compiler version, optimization level and architecture combination proves little.
> 
> For sure, Coverity would complain about this (if we ever had it working again). The fact is that it is dead code and dead code is wrong.
I just reverted the missing returns.
Though the rest of VLC is not very consistent either.

Second thing is. Does somebody know witch compilers support "__attribute__((unused))"?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100825/552a3762/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-removed-some-trivial-warnings.patch
Type: application/octet-stream
Size: 19344 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100825/552a3762/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100825/552a3762/attachment-0001.html>


More information about the vlc-devel mailing list