[vlc-devel] [PATCH 2/2] Fix libvlc_media_get_tracks_info()

[Laurent Aimar]

On Thu, Dec 02, 2010 at 06:53:54PM +0100, Rémi Denis-Courmont wrote:
> 
> On Thu,  2 Dec 2010 09:49:29 +0100, Rafaël Carré <rafael.carre at gmail.com>
> wrote:
> >          /* We've found the right ES, replace it */
> > +        /* FIXME: Unless it's not really the right ES */
> > +        if (item->es[i]->i_codec == fmt->i_codec)
> > +        {
> >          es_format_Clean(item->es[i]);
> >          free(item->es[i]);
> >          item->es[i] = fmt_copy;
> > +        }
> 
> Without context: it looks like fmt_copy is leaked when the new predicate is
> false.
> 
> We really need unique IDs for each ES. But I do not believe it can be
> implemented in a generic way - each and every demuxer must support it.
 After the demuxer, they are unique. But I think there is an issue when updating
the es format from the decoder. I will have to check.

-- 
fenrir