[vlc-devel] Patch for C64 SID suppport

[Jean-Baptiste Kempf]

On Mon, Dec 06, 2010 at 10:28:24PM -0600, Alan Fischer wrote :
> I apologize if this email arrives twice, I initially sent it from the wrong
> account, which is not subscribed to the list.

Yes, they get moderated afterwards, around once a day.


> ---
>  configure.ac             |   19 +++
>  modules/demux/Modules.am |    1 +
>  modules/demux/sid.cpp    |  285 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 305 insertions(+), 0 deletions(-)
>  create mode 100644 modules/demux/sid.cpp
> 
> diff --git a/configure.ac b/configure.ac
> index cf50be3..6a7fe6b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2310,6 +2310,25 @@ AS_IF([test "${enable_gme}" != "no"], [
>  
>  
>  dnl
> +dnl  SIDPlay plugin
> +dnl
> +AC_ARG_ENABLE(sid,
> +  [  --enable-sid            C64 sid demux support (default auto)])
> +AS_IF([test "${enable_sid}" != "no"], [
> +  PKG_CHECK_MODULES(SIDPLAY2, [libsidplay2], [
> +    VLC_ADD_CFLAGS([sid], [$SIDPLAY2_CFLAGS])
> +    VLC_ADD_LIBS([sid], [$SIDPLAY2_LIBS])
> +    VLC_ADD_LIBS([sid], [-lresid-builder])
> +    VLC_ADD_PLUGIN([sid])
> +  ], [
> +    AS_IF([test x"${enable_sid}" = "xyes"],
> +      [AC_MSG_ERROR([libsidplay2 was not found])],
> +      [AC_MSG_WARN([libsidplay2 was not found])])
> +  ])
> +])


PKG_ENABLE_MODULES_VLC maybe?
C++ Pop/Push maybe?

> +    if (i_read<=0)
> +    {
inconsistent codestyle

When I meant alignment, I meant code style alignment for assignments =>
more readable code.



Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734