[vlc-devel] [PATCH] Add Dirac encoding support to VLC using the Schroedinger library.

[Kaarlo Räihä]

2010/12/16 Anuradha Suraparaju <asuraparaju at gmail.com>

> Hi,
>
> On Wed, Dec 8, 2010 at 10:52 PM, Jean-Baptiste Kempf <jb at videolan.org>wrote:
>
>> On Wed, Dec 08, 2010 at 02:43:21PM +1100, Anuradha Suraparaju wrote :
>> > > I just set it to the value used by the decoder. Is there any way pf
>> > specifying that the Schro encoder module should be used ahead of the
>> > Dirac-research encoder module to encode Dirac if both are present?
>> Anything above "100" would work.
>>
>
> Will change it to 110 from 200.
>
>
>>
>> > > It seems that most of the code is options handling. Would it be
>> possible
>> > > to automatize this part and reduce the code size?
>> > > I am not sure we need proper internalization of all the options, but
>> > > maybe I am wrong.
>> > >
>> > Most of the options are advanced options that can be used to tweak the
>> > Schroedinger encoder output. So the end user is unlikely to use them
>> often.
>> > I'll see if I can get rid of some of the advanced options. Schro encoder
>> > does provide an interface to the encoding options. I'll see if I can use
>> > that to reduce the code size.
>>
>> I didn't say "get rid of", I surely didn't.
>> I just asked if it was possible to automatically generate them. If it is
>> too much hassle, don't bother.
>>
>
> I've taken a look at the schro encoding options retrieval and it is bit of
> a hassle. So I've decided to keep things they way they are.
>
>
>>
>> But, still some MACROS should help factorize the code, IMVVVHO
>>
>>
> Have  introduced macros to reduce code length.
>
> Should I send a fresh patch from scratch or a patch to the previous one I
> sent?
>

A fresh patch from scratch is usually better if modifications are
non-cosmetic.


>
> Regards,
> Anuradha
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20101216/1425f1b0/attachment.html>