[vlc-devel] [PATCH] Add Dirac encoding support to VLC using the Schroedinger library.

[Jean-Baptiste Kempf]

On Fri, Dec 17, 2010 at 07:11:43PM +1100, Anuradha Suraparaju wrote :
> I have attached a fresh patch to this email.

Thanks a lot.

> +  N_("Inter pictures can refer to previoius or future pictures"),
> +  N_("Inter pictures can refer to previoius or future pictures")
previoius or previous?

> +#define ENC_CODINGMODE_TEXT N_("Picture coding mode")
> +#define ENC_CODINGMODE_LONGTEXT N_("Field coding is where interlaced fields are coded" \
> +                                   " separately as opposed to a pseudo-progressive frame")
maybe mention the possible values in the help?

You use "_" in the option names, but I believe the more classical way in
VLC is to use "-" for --schroedinger-sout-long-name

You should create add_shortcut( "schro" ) IMVHO

> +#define SCHRO_SET_FLOAT(psz_name) \
> +
> +#define SCHRO_SET_INTEGER(psz_name, pschro_name, ignore_val) \
> +
> +#define SCHRO_SET_ENUM(list,psz_name, psz_name_text) \

Very cosmetic (highly not important) You should define those macros just
before you use them (just before OpenEncoder, in fact).

Else, I have nothing much to complain about :D

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734