[vlc-devel] [PATCH 1/2] New ProjectM API (libvlc)

[XilasZ]

Hi all,

After some research and advices, i've made a new version, without using
vlc_object_find_name or p_owner.
Before porting it to the master branch and sending a patch, i'd would like
to know your opinion on what i did.

I added 3 variables and a callback inside aout (created in InputNew when
projectm in created, destroyed in InputDelete, so that they should have the
same lifecycle as projectm module).
I gave the p_filter to the callback at its creation.
So libvlc set/get variables to the aout, then the aout callback set/get
variables to the filter, and the filter react and do his job.
If projectm is not used, variables doesn't exists in the aout, so nothing
happens.

I also added 3 settings to projectm module to set meshx, meshy and
texturesize.

It seems stable so far. What do you think ?

I've tested this on the 1.1 branch, i hope it works the same way on 1.2 :/

On Fri, Dec 10, 2010 at 11:13 PM, XilasZ <xilasz at gmail.com> wrote:

> I'm not asking for detailled instructions, just directions is fine.
>
>
> > In general though, control requests should be passed through the input
> thread, and then down the streaming pipeline as appropriate.
>
> Can it work both ways ?
>
> 2010/12/10 Rémi Denis-Courmont <remi at remlab.net>
>
>>
>> On Fri, 10 Dec 2010 08:58:46 +0100, XilasZ <xilasz at gmail.com> wrote:
>> > I know what deprecated means thanks ... I sent the patch anyway, hoping
>> for
>> > some advices from senior vlc devs, it seems i was wrong :/
>>
>> My advise is to not use deprecated functions.
>>
>> I can't tell you a detailed solution to your problem since I have no clue
>> how ProjectM works within VLC. In general though, control requests should
>> be passed through the input thread, and then down the streaming pipeline
>> as
>> appropriate.
>>
>> --
>> Rémi Denis-Courmont
>> http://www.remlab.net
>> http://fi.linkedin.com/in/remidenis
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> http://mailman.videolan.org/listinfo/vlc-devel
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20101219/e4ac4fc8/attachment.html>