[vlc-devel] [PATCH] Ticket #2234: Add an option to pause the playback on minimizing the window

Jean-Baptiste Kempf jb at videolan.org
Sat Dec 25 23:10:10 CET 2010

On Sat, Dec 25, 2010 at 11:06:55PM +0100, Jakub Wieczorek wrote :
> 2010/12/25 Jean-Baptiste Kempf <jb at videolan.org>:
> > On Fri, Dec 24, 2010 at 07:41:55PM +0100, Jakub Wieczorek wrote :
> >> Actually, this should probably be done in a follow-up patch. Attaching
> >> two separate ones.
> >>
> >
> > Why removing the const; in the 2nd patch?
> Do you mean it shouldn't be removed or that it shouldn't be in the 1st
> patch at all? If the former - that's what you suggested doing on IRC
> (as that qualifier isn't really used consistently in that code,
> indeed), if the latter, that's a mistake - I'll fix it.

Well, I don't know, I just find it weird this removal in a cosmetics

To be honest, I would do the renaming + adding the playinStatus() method
in a first patch, and then do a second patch with the minimizing

Best Regards,

Jean-Baptiste Kempf
+33 672 704 734

More information about the vlc-devel mailing list