[vlc-devel] [PATCH] CrystalHD - interlace support

[Jean-Baptiste Kempf]

Hello,

On Wed, Dec 29, 2010 at 05:13:57PM +0100, R.M. wrote :
> +static BC_DTS_PROC_OUT proc_out_prev;
Please avoid that. Add it in the p_sys struct if you need it.

> +	memset( &proc_out_prev, 0, sizeof(BC_DTS_PROC_OUT) );
Do it with the other initialisations.

> +	if (proc_out_prev.Ybuff)
> +	{
> +		free(proc_out_prev.Ybuff);
> +		proc_out_prev.Ybuff = NULL;
> +	}
Drop the if

> -    proc_out.PoutFlags      = BC_POUT_FLAGS_SIZE;                           //FIXME why?
> +    proc_out.PoutFlags      = BC_POUT_FLAGS_SIZE;                        //FIXME why?
Useless modification.

> +			if (proc_out.PicInfo.flags&VDEC_FLAG_INTERLACED_SRC)
> +			{
> +				if (!proc_out_prev.Ybuff)
> +				{
> +					proc_out_prev = proc_out;
> +					return NULL;
> +				}
> +				
> +				bool bottom;
> +
> +				if (proc_out_prev.PoutFlags&BC_POUT_FLAGS_FLD_BOT) 
> +				{
> +					bottom = TRUE;	
> +				}
> +				else
> +				{
> +					bottom = FALSE;
> +				}
true or false not TRUE FALSE

You should be careful about removing tabs, not adding trailing spaces,
and respecting codestyle.


Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734