[vlc-devel] [PATCH] Added IVTC deinterlacer (NTSC film mode)

[Jean-Baptiste Kempf]

On Fri, Dec 31, 2010 at 03:57:13PM +0200, Juha Jeronen wrote :
> What should we do about the name shown to the user? Relabel as "IVTC (NTSC film)" to reach both camps of users?
I believe the code should refer to IVTC, since it is the most exact
term. The user display could be Film NTSC (IVTC) or something of the
like.

> Mm, maybe I should use int_fast32_t instead. What I basically want there is simply enough space to handle (P - C)*(N - C) in all cases, and keep it as "native" as possible so that the speed doesn't suffer unnecessarily. This requires at least 17 bits (worst case: both (P - C) and (N - C) are plus or minus 255), so 32 is the smallest size that will work.

long is not native, this is exactly my point. On Win64, long ain't of
the stack size.

> How to quit a filter nicely in VLC? Any suggestions where I should look? None of the other deinterlacers quit, so in this module there was no example of that.
return NULL ?

> Please let me know what you think about the name issue, whether the loop counters should be defined in the for or outside it, and the quit issue. Once these are decided, I'll get to work :)
for, do as you want. name, see as above.
Quit, I need Laurent to tell us.

> Thanks for the analysis!
Was just a quick review :)

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734