[vlc-devel] commit: various modules: adjust to new playlist design (Jakob Leben )

[Pierre d'Herbemont]

Hey Jakob,

I am sorry I missed this previously:

-        input_item_AddSubItem( input_GetItem( p_input ), p_new_loc );
+        input_item_t *p_item = input_GetItem( p_input );
+        input_item_AddSubItem( p_item, p_new_loc );
+        input_item_AddSubItem2( p_item, p_new_loc );

Well, input_item_AddSubItem2 is non obvious. Very suspicious.

+    input_item_node_t *p_subitems = input_item_node_Create( p_current_input );

Why do you need this? Couldn't you emulate this with input_item_AddSubItem()?

It seems that this new API is much more complicated than it was
before, and there is no reason why. Mostly everything could be done on
top of the previous API.

Pierre.

On Tue, Feb 2, 2010 at 6:56 AM, git version control <git at videolan.org> wrote:
> vlc | branch: master | Jakob Leben <jleben at videolan.org> | Tue Feb  2 04:24:18 2010 +0100| [2531d5144140a1b5ca3b13419c979c53e0c951ab] | committer: Jakob Leben
>
> various modules: adjust to new playlist design
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2531d5144140a1b5ca3b13419c979c53e0c951ab
> ---
>
>  modules/access/cdda.c                              |    6 ++++
>  modules/access/mms/mmsh.c                          |    5 +++-
>  modules/demux/mp4/mp4.c                            |    5 +++
>  modules/demux/playlist/asx.c                       |   10 +++++++
>  modules/demux/playlist/b4s.c                       |   10 +++++++
>  modules/demux/playlist/dvb.c                       |    6 ++++
>  modules/demux/playlist/gvp.c                       |    6 ++++
>  modules/demux/playlist/ifo.c                       |    3 ++
>  modules/demux/playlist/m3u.c                       |    4 +++
>  modules/demux/playlist/pls.c                       |    7 +++++
>  modules/demux/playlist/podcast.c                   |   11 ++++++++
>  modules/demux/playlist/qtl.c                       |    5 +++
>  modules/demux/playlist/ram.c                       |    5 +++
>  modules/demux/playlist/sgimb.c                     |    1 +
>  modules/demux/playlist/shoutcast.c                 |   27 ++++++++++++-------
>  modules/demux/playlist/wpl.c                       |    8 ++++++
>  modules/demux/playlist/zpl.c                       |    7 +++++
>  modules/gui/macosx/playlist.m                      |    5 +--
>  modules/gui/qt4/components/playlist/playlist.cpp   |    4 +-
>  .../gui/qt4/components/playlist/standardpanel.cpp  |   14 ++++++---
>  modules/misc/lua/vlc.c                             |    3 ++
>  modules/services_discovery/upnp_cc.cpp             |    4 +-
>  22 files changed, 133 insertions(+), 23 deletions(-)
>
> Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=2531d5144140a1b5ca3b13419c979c53e0c951ab
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>