[vlc-devel] commit: itml: new playlist design (Jakob Leben )

Pierre d'Herbemont pdherbemont at free.fr
Tue Feb 2 09:03:55 CET 2010


On Tue, Feb 2, 2010 at 6:56 AM, git version control <git at videolan.org> wrote:
> vlc | branch: master | Jakob Leben <jleben at videolan.org> | Tue Feb  2 04:19:32 2010 +0100| [128fadfc47eb56908f2c42b2ca28a0aed5fcb354] | committer: Jakob Leben
>
> itml: new playlist design
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=128fadfc47eb56908f2c42b2ca28a0aed5fcb354
> ---
>
>  modules/demux/playlist/itml.c |   32 ++++++++++++++++++--------------
>  modules/demux/playlist/itml.h |    2 +-
>  2 files changed, 19 insertions(+), 15 deletions(-)
>
> diff --git a/modules/demux/playlist/itml.c b/modules/demux/playlist/itml.c
> index 05c0fce..c6235a8 100644
> --- a/modules/demux/playlist/itml.c
> +++ b/modules/demux/playlist/itml.c
> @@ -101,10 +101,13 @@ int Demux( demux_t *p_demux )
>         goto end;
>     }
>
> +    input_item_node_t *p_subitems = input_item_node_Create( p_current_input );
>     xml_elem_hnd_t pl_elements[] =
>         { {"dict",    COMPLEX_CONTENT, {.cmplx = parse_plist_dict} } };
> -    parse_plist_node( p_demux, p_current_input, NULL, p_xml_reader, "plist",
> +    parse_plist_node( p_demux, p_subitems, NULL, p_xml_reader, "plist",
>                       pl_elements );
> +    input_item_AddSubItemTree( p_subitems );

Should it be input_item_AddSubItemTree(p_item, p_subitem)? Else, name
it input_item_node_RegisterToSubItem or whatever.

> +    input_item_node_Delete( p_subitems );

Do you really delete it now? I preferred your old design when your API
was simpler. Let the input_item API simple, this add crappy playlist
complexity back in the input_item. :/

Pierre.



More information about the vlc-devel mailing list