[vlc-devel] commit: various modules: adjust to new playlist design (Jakob Leben )

[Pierre d'Herbemont]

On Tue, Feb 2, 2010 at 5:33 PM, Jakob Leben <jakob.leben at gmail.com> wrote:

> Look, how can you avoid the various node manipulation functions, when it is
> the modules that have to construct an input item tree? Only they know how to
> construct it, that is why they are there.

This can be done with input_item_New() and input_item_AddSubitem().
And a Flush function. Much more robust, lighter, and compatible with
what we had.

> For the moment, for judging the new API, think that input_item_AddSubitem
> calls are not there, because that will be removed. Or actually
> input_item_AddSubitem will be removed and the version 2 will come in its
> place.

I got this. The naming is just wrong. First because of confusion with
the previous one, then because there is no flush notion what so ever.
You had to explain the difference to me, that prove that this was not
rightly named.

>>>>>> So here you could help me out. You could convert your
>>>>>> src/control/media.c to listen to vlc_InputItemSubItemTreeAdded event instead
>>>>>> and process the incoming tree structure. <<<<<

You see how much complexity it adds? I'd rather implement your API on
top of the previous one. I think what you've done is great, but the
module interface can be simplified.

Thanks, I hope we'll move forward.

Pierre.