[vlc-devel] commit: Lua dialogs: remove show() and hide() ( Jean-Philippe André )

[git version control]

vlc | branch: master | Jean-Philippe André <jpeg at videolan.org> | Wed Feb  3 17:52:49 2010 +0100| [67d36fd7c71ff213ac363d092d59290b1a943980] | committer: Jean-Philippe André 

Lua dialogs: remove show() and hide()

Lua dialogs are deleted when closed, they can't be hidden or shown.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=67d36fd7c71ff213ac363d092d59290b1a943980
---

 modules/misc/lua/extension.c   |    2 +-
 modules/misc/lua/libs/dialog.c |   38 --------------------------------------
 2 files changed, 1 insertions(+), 39 deletions(-)

diff --git a/modules/misc/lua/extension.c b/modules/misc/lua/extension.c
index 2a6f404..b703860 100644
--- a/modules/misc/lua/extension.c
+++ b/modules/misc/lua/extension.c
@@ -83,7 +83,7 @@ static void inputItemMetaChanged( const vlc_event_t *p_event,
  **/
 int Open_Extension( vlc_object_t *p_this )
 {
-    msg_Dbg( p_this, "Opening EXPERIMENTAL Lua Extension module" );
+    msg_Dbg( p_this, "Opening Lua Extensions module" );
 
     extensions_manager_t *p_mgr = ( extensions_manager_t* ) p_this;
 
diff --git a/modules/misc/lua/libs/dialog.c b/modules/misc/lua/libs/dialog.c
index e38faa9..ffb2ec0 100644
--- a/modules/misc/lua/libs/dialog.c
+++ b/modules/misc/lua/libs/dialog.c
@@ -50,8 +50,6 @@
 /* Dialog functions */
 static int vlclua_dialog_create( lua_State *L );
 static int vlclua_dialog_delete( lua_State *L );
-static int vlclua_dialog_show( lua_State *L );
-static int vlclua_dialog_hide( lua_State *L );
 static int vlclua_dialog_flush( lua_State *L );
 static void lua_SetDialogUpdate( lua_State *L, int flag );
 static int lua_GetDialogUpdate( lua_State *L );
@@ -99,8 +97,6 @@ static int DeleteWidget( extension_dialog_t *p_dialog,
                          extension_widget_t *p_widget );
 
 static const luaL_Reg vlclua_dialog_reg[] = {
-    { "show", vlclua_dialog_show },
-    { "hide", vlclua_dialog_hide },
     { "close", vlclua_dialog_delete },
     { "flush", vlclua_dialog_flush },
 
@@ -288,40 +284,6 @@ static int vlclua_dialog_delete( lua_State *L )
     return 1;
 }
 
-/** Show the dialog */
-static int vlclua_dialog_show( lua_State *L )
-{
-    vlc_object_t *p_mgr = vlclua_get_this( L );
-
-    extension_dialog_t **pp_dlg =
-            (extension_dialog_t**) luaL_checkudata( L, 1, "dialog" );
-    if( !pp_dlg || !*pp_dlg )
-        return luaL_error( L, "Can't get pointer to dialog" );
-    extension_dialog_t *p_dlg = *pp_dlg;
-
-    p_dlg->b_hide = false;
-    lua_SetDialogUpdate( L, 1 );
-
-    return 1;
-}
-
-/** Hide the dialog */
-static int vlclua_dialog_hide( lua_State *L )
-{
-    vlc_object_t *p_mgr = vlclua_get_this( L );
-
-    extension_dialog_t **pp_dlg =
-            (extension_dialog_t**) luaL_checkudata( L, 1, "dialog" );
-    if( !pp_dlg || !*pp_dlg )
-        return luaL_error( L, "Can't get pointer to dialog" );
-    extension_dialog_t *p_dlg = *pp_dlg;
-
-    p_dlg->b_hide = true;
-    lua_SetDialogUpdate( L, 1 );
-
-    return 1;
-}
-
 
 /** Flush the dialog */
 static int vlclua_dialog_flush( lua_State *L )