[vlc-devel] commit: Lua dialogs: remove b_hide parameter ( Jean-Philippe André )

[Toralf Niebuhr]

Why was this parameter removed?

How can I check if the dialog needs to be hidden.

Toralf

Am 03.02.2010 um 18:05 schrieb git version control:

> vlc | branch: master | Jean-Philippe André <jpeg at videolan.org> | Wed Feb  3 17:58:29 2010 +0100| [6787595024f61d65d68a1fe467e6520c75756b20] | committer: Jean-Philippe André 
> 
> Lua dialogs: remove b_hide parameter
> 
> Widgets can still be hidden though
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6787595024f61d65d68a1fe467e6520c75756b20
> ---
> 
> include/vlc_extensions.h               |    1 -
> modules/gui/qt4/dialogs/extensions.cpp |    3 +--
> 2 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/include/vlc_extensions.h b/include/vlc_extensions.h
> index 7d94524..a267199 100644
> --- a/include/vlc_extensions.h
> +++ b/include/vlc_extensions.h
> @@ -195,7 +195,6 @@ struct extension_dialog_t
> 
>     DECL_ARRAY(extension_widget_t*) widgets; ///< Widgets owned by the dialog
> 
> -    bool b_hide;                 ///< Hide this dialog (!b_hide shows)
>     bool b_kill;                 ///< Kill this dialog
> 
>     void *p_sys;                 ///< Dialog private pointer
> diff --git a/modules/gui/qt4/dialogs/extensions.cpp b/modules/gui/qt4/dialogs/extensions.cpp
> index e2da271..829dc34 100644
> --- a/modules/gui/qt4/dialogs/extensions.cpp
> +++ b/modules/gui/qt4/dialogs/extensions.cpp
> @@ -110,14 +110,13 @@ ExtensionDialog* ExtensionsDialogProvider::UpdateExtDialog(
>     if( !p_dialog->b_kill && !dialog )
>     {
>         dialog = CreateExtDialog( p_dialog );
> -        dialog->setVisible( !p_dialog->b_hide );
> +        dialog->setVisible( true );
>     }
>     else if( !p_dialog->b_kill && dialog )
>     {
>         dialog->has_lock = true;
>         dialog->UpdateWidgets();
>         dialog->has_lock = false;
> -        dialog->setVisible( !p_dialog->b_hide );
>     }
>     else if( p_dialog->b_kill )
>     {
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel