[vlc-devel] commit: Sqlite: Unlock commit transaction on success, not fail ( Srikanth Raju )

git version control git at videolan.org
Thu Feb 4 03:11:38 CET 2010


vlc | branch: master | Srikanth Raju <srikiraju at gmail.com> | Wed Feb  3 21:29:06 2010 +0530| [d6b0343a811e075b3bacc5a6b6c51fbbc14365ab] | committer: Jean-Philippe André 

Sqlite: Unlock commit transaction on success, not fail

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d6b0343a811e075b3bacc5a6b6c51fbbc14365ab
---

 modules/misc/sqlite.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/modules/misc/sqlite.c b/modules/misc/sqlite.c
index 6aad027..360577f 100644
--- a/modules/misc/sqlite.c
+++ b/modules/misc/sqlite.c
@@ -451,9 +451,10 @@ static int CommitTransaction( sql_t* p_sql )
         msg_Warn( p_sql, "sqlite3 error: %d: %s",
                   sqlite3_errcode( p_sql->p_sys->db ),
                   sqlite3_errmsg( p_sql->p_sys->db ) );
-        vlc_mutex_unlock( &p_sql->p_sys->trans_lock );
         i_ret = VLC_EGENERIC;
     }
+    else
+        vlc_mutex_unlock( &p_sql->p_sys->trans_lock );
     vlc_mutex_unlock( &p_sql->p_sys->lock );
     return i_ret;
 }




More information about the vlc-devel mailing list