[vlc-devel] commit: Fixed an invalid free in input_item_DelInfo(). (Laurent Aimar )

git version control git at videolan.org
Fri Feb 5 22:36:19 CET 2010


vlc | branch: master | Laurent Aimar <fenrir at videolan.org> | Fri Feb  5 21:56:49 2010 +0100| [81d5bdde444273952bc1149c29be33f71e842288] | committer: Laurent Aimar 

Fixed an invalid free in input_item_DelInfo().

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=81d5bdde444273952bc1149c29be33f71e842288
---

 src/input/item.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/input/item.c b/src/input/item.c
index e6f1701..114987e 100644
--- a/src/input/item.c
+++ b/src/input/item.c
@@ -716,11 +716,9 @@ int input_item_DelInfo( input_item_t *p_i,
         }
         free( p_cat->pp_infos );
         REMOVE_ELEM( p_i->pp_categories, p_i->i_categories, i_cat );
+        free( p_cat->psz_name );
+        free( p_cat );
     }
-
-    // Free the category
-    free( p_cat->psz_name );
-    free( p_cat );
     vlc_mutex_unlock( &p_i->lock );
 
 




More information about the vlc-devel mailing list