[vlc-devel] commit: Use C locale when formatting error messages in the log ( Rémi Denis-Courmont )

[Toralf Niebuhr]

Am 06.02.2010 um 15:43 schrieb Rémi Denis-Courmont:

> Le samedi 6 février 2010 16:37:30 Toralf Niebuhr, vous avez écrit :
>> This commit breaks the build for VLCKit (Mac OS X)
>> The Header "xlocale.h" should be included somewhere I just don't know whats
>> the right place. Including it in "include/vlc_fixups.h" works for me, but
>> it's definitely not the right place.
>> 
>> Any suggestions?
> 
> Fix your operating system.
Where do you have this from?
When I look at the definition of locale.h at www.opengroup.org, I find no reference of these functions or that type in that file there.
All thats supposed to be defined in locale.h are the LC_* macros and the functions localeconv and setlocale.

I might be wrong, but just claiming that the operating system is to blame is no help either. And even if it's the fault of Mac OS X, shouldn't xlocale.h be included with some #ifdef for platform independence reasons?

Toralf
> 
> | The <locale.h> header shall define the locale_t type, representing a
> | locale object.
> | The following shall be declared as functions and may also be defined
> | as macros. Function prototypes shall be provided for use with ISO C
> | standard compilers.
> (...)
> | void          freelocale(locale_t);
> (...)
> | locale_t      newlocale(int, const char *, locale_t);
> (...)
> | locale_t      uselocale (locale_t);
> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> http://fi.linkedin.com/in/remidenis
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel