[vlc-devel] commit: zvbi: Fix displaying of teletext and closed captioning. ( Jean-Paul Saman )

[Jean-Paul Saman]

On Fri, Feb 5, 2010 at 8:25 PM, Laurent Aimar <fenrir at via.ecp.fr> wrote:
> On Fri, Feb 05, 2010, Laurent Aimar wrote:
>> On Fri, Feb 05, 2010, Laurent Aimar wrote:
>> > On Fri, Feb 05, 2010, Jean-Paul Saman wrote:
>> > > On Fri, Feb 5, 2010 at 2:13 PM, Laurent Aimar <fenrir at via.ecp.fr> wrote:
>> > > >  If the issue is that p_block->i_pts is 0, then as I told you, it is not the
>> > > > right place to fix it. It *must* be fixed either in src/input/decoder.c or
>> > > > es_out.c
>> > >
>> > > I'll investigate but in the mean time working closed captions/teletext
>> > > is preferable to non working at all.
>> >  IMO, hacks do not belong to master, but could be acceptable in the stabilization
>> > branches (if accepted).
>> >  At least, they should be marked as such with a #warning and clearly specified in
>> > the commit log.
>>  To be clear, this patch should be reverted, as
>> src/input/decoder.c::DecoderTeletextFixTs already does the job.
>>  If it does not, this should be investigated and correctly fixed here.
>  In order to try to fix it, do you have any samples with this issue availables ?
>

Yes I have. I'll pm you the location.

Gtz
Jean-Paul Saman