[vlc-devel] commit: Fix VLM scheduling. (Antoine Cellerier )

Rémi Denis-Courmont remi at remlab.net
Mon Feb 8 21:42:56 CET 2010


Le lundi 8 février 2010 22:36:58 git version control, vous avez écrit :
> vlc | branch: master | Antoine Cellerier <dionoea at videolan.org> | Mon Feb 
>  8 21:38:08 2010 +0100| [d84370a8519245f27883dd59c0ce406a5af48a61] |
>  committer: Antoine Cellerier
> 
> Fix VLM scheduling.

Locking seems quite dubious here. Unless I am missing something, the same lock 
that protect the VLM schedule should protect the condition variable.

It's not just a matter of (possibly negligible and in any case unlikely) 
spurious wakeups. Some lock has to protect the state between the management 
thread and users of the VLM functions.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis



More information about the vlc-devel mailing list