[vlc-devel] commit: skins2: update to latest change in core (Erwan Tulou )

git version control git at videolan.org
Tue Feb 9 11:54:57 CET 2010


vlc | branch: master | Erwan Tulou <erwan10 at videolan.org> | Tue Feb  9 10:58:27 2010 +0100| [d49c428062ae7a6e22cc5c1f9f78cd3d72e21610] | committer: Erwan Tulou 

skins2: update to latest change in core

 - remove pf_run no longer in use
 - attach object as soon as possible to benefit var heritage

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d49c428062ae7a6e22cc5c1f9f78cd3d72e21610
---

 modules/gui/skins2/src/dialogs.cpp |   13 +++----------
 1 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/modules/gui/skins2/src/dialogs.cpp b/modules/gui/skins2/src/dialogs.cpp
index 611468a..304172b 100644
--- a/modules/gui/skins2/src/dialogs.cpp
+++ b/modules/gui/skins2/src/dialogs.cpp
@@ -158,6 +158,9 @@ bool Dialogs::init()
     if( m_pProvider == NULL )
         return false;
 
+    // Attach the dialogs provider to its parent interface
+    vlc_object_attach( m_pProvider, getIntf() );
+
     m_pModule = module_need( m_pProvider, "dialogs provider", NULL, false );
     if( m_pModule == NULL )
     {
@@ -167,16 +170,6 @@ bool Dialogs::init()
         return false;
     }
 
-    // Attach the dialogs provider to its parent interface
-    vlc_object_attach( m_pProvider, getIntf() );
-
-    // Initialize dialogs provider
-    // (returns as soon as initialization is done)
-    if( m_pProvider->pf_run )
-    {
-        m_pProvider->pf_run( m_pProvider );
-    }
-
     /* Register callback for the intf-popupmenu variable */
     var_AddCallback( getIntf()->p_libvlc, "intf-popupmenu",
                      PopupMenuCB, this );




More information about the vlc-devel mailing list