[vlc-devel] commit: services_discovery: fix embedding translated longname into name ( Jakob Leben )

[Rémi Denis-Courmont]

On Wed, 10 Feb 2010 00:57:47 +0100, Jakob Leben <jakob.leben at gmail.com>
wrote:
> 2010/2/9 Rémi Denis-Courmont <remi at remlab.net>
> 
>> Le mardi 9 février 2010 20:02:04 git version control, vous avez écrit
> :
>> > vlc | branch: master | Jakob Leben <jleben at videolan.org> | Tue Feb  9
>> >  19:00:45 2010 +0100| [caa08dce07c3b08677645263e325b33148f536bd] |
>> >  committer: Jakob Leben
>> >
>> > services_discovery: fix embedding translated longname into name
>>
>> Fix??
>>
> 
> The point is: modules do:  VLC_SD_PROBE_HELPER( "name", N_("longname") )
> which when expanding # longname in the macro results in a literal
> "N_(\"longname\"" instead of translated longname string. That's wrong.

Then fix the macro instead of adding an obvious buffer overflow (so obvious
that it makes my glibc abort in sprintf).

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis