[vlc-devel] [PATCH] -- fake module for still images uris

[brezhoneg1]

Hi,

>On Wed, Feb 10, 2010, brezhoneg1 wrote:
>> - patch4:
>>    supporting still images in their uri format (file://...) has
become
>> really needed.
>>    I know fake module isn't regarded as the best design, but at
least,
>> it works fine.

> I think the only good way is to not use the fake module (which is an
ugly
>hack), but simply to create a new demuxer.
>

>>    Having it detect these uri should still be better than just
getting
>> error dialog boxes ?

> IMHO, no, because the fake demuxer will only check the extension which
is very
>dangerous especially as it is an access_demux and will bypass the whole
>content detection.

Generally speaking, a content-based detection sounds more robust than an
extension-based one.

But, as a second thought, still image might be an exception to the rule.
still image and video often share the same content (same codec) and
extension can be the key element to differentiate them. For instance,
.jpg files are likely to be still images, but a content-based detection
sees them as a mjpeg video with 1 frame. (That's actually what really
happens with no good result). Extension can provide the extra hint that
it is not a video.

Having a first filter based on well-known extensions to separate still
images may actually be a sane approach, when content-based may lead to
misinterpretation. Of course, this set of extensions must be kept as
small as possible.

Also, file/demux://.... can still be used if a video happens to use a
well-known still image extension. (That should not happen that often)

If fake were to be rewritten as a true image demux, the same problem
would still exist as to which demux would be chosen based on content or
extension.

>From a user's viewpoint, still images have become a useful feature in
vlc, and whatever the demux, supporting file:// should be seen as a must
for vlc1.1. (saving them in xspf playlist, drag&drop, ... ).

Regards
Erwan10