[vlc-devel] commit: libvlc: add mouse events as libvlc_MediaPlayerEvents ( Jean-Paul Saman )

[Laurent Aimar]

On Thu, Feb 11, 2010, Jean-Paul Saman wrote:
> On Thu, Feb 11, 2010 at 12:20 PM, Laurent Aimar <fenrir at via.ecp.fr> wrote:
> > On Thu, Feb 11, 2010, git version control wrote:
> >> vlc | branch: master | Jean-Paul Saman <jean-paul.saman at m2x.nl> | Fri Feb  5 14:13:29 2010 +0100| [114b922fa7bbe06f4acfcc3d7af9c47ef534b1a2] | committer: Jean-Paul Saman
> >>
> >> libvlc: add mouse events as libvlc_MediaPlayerEvents
> >>
> >> The following events have been added:
> >> - MouseButton : mouse button pressed events
> >> - MouseClick  : mouse button click event
> >> - MouseMoved  : mouse movement event (x,y) absolute against vlc video output window
> >> - MouseObject : object of interest under mouse button for use by video filters (like: logo)
> >
> > Attaching mouse-object to vout_thread_t seems a bad idea to me as it used only by
> > the logo filter.
> >  IMO, it should be moved to the logo filter instead.
> 
> But how do I obtain the logo filter object then? Without
> vlc_object_find_name() ??

 A new function that can retreive a filter (or a filter list) from
the vout is needed (like it was added for retreiving the decoder objects).

But using vlc_object_find_name or ->p_parent are both ugly and dangerous
(dunno which one is worst) and so no new uses should be added.

-- 
fenrir