[vlc-devel] commit: DBus: ifdef buggy input code out ( Rémi Denis-Courmont )

[Rémi Denis-Courmont]

Le jeudi 11 février 2010 16:30:10 Rafaël Carré, vous avez écrit :
> On Tue,  9 Feb 2010 22:34:20 +0100 (CET)
> 
> git at videolan.org (git version control) wrote:
> > vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue
> > Feb  9 23:34:00 2010 +0200|
> > [f5bd90eb0e568b340a2809337a5b0b3e56e463e6] | committer: Rémi
> > Denis-Courmont
> >
> > DBus: ifdef buggy input code out
> >
> > > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f5bd90eb0e568b34
> > >0a2809337a5b0b3e56e463e6
> >
> > ---
> >
> >  modules/control/dbus.c |    9 +++++----
> >  1 files changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/modules/control/dbus.c b/modules/control/dbus.c
> >
> >
> > +#if 0
> >      var_AddCallback( p_input, "state", AllCallback, p_intf );
> > -
> > -    vlc_object_release( p_input );
> > +#endif
> >      return VLC_SUCCESS;
> >  }
> 
> What's wrong here : adding the callback without keeping a reference ?

Yes. The callback is not deleted properly either.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis