[vlc-devel] commit: vlm: Remove the callback before joining the thread, and save a dead lock. (Pierre d'Herbemont )

[Pierre d'Herbemont]

On Thu, Feb 11, 2010 at 9:07 PM, Sébastien Escudier
<sebastien-devel at celeos.eu> wrote:
> Quoting git version control <git at videolan.org>:
>
>> vlc | branch: master | Pierre d'Herbemont <pdherbemont at free.fr> | Thu Feb 11
>> 20:34:30 2010 +0100| [f4bc3b96d4062f2518ef55848115504f468c3f1f] | committer:
>> Pierre d'Herbemont
>>
>> vlm: Remove the callback before joining the thread, and save a dead lock.
>
>> +        var_DelCallback( p_instance->p_input, "intf-event", InputEvent,
>> p_media );
>> +
>>          input_Stop( p_input, true );
>>          vlc_thread_join( p_input );
>
> but then we are loosing some events.

Which one would you expect? The correct fix is trivial if you want the
Stop event.

Pierre.