[vlc-devel] [PATCH] Enable Lua SD loading with -S<name>

Fabio Ritrovato exsephiroth87 at gmail.com
Tue Feb 16 22:26:58 CET 2010


2010/2/16 Rémi Denis-Courmont <remi at remlab.net>:
> Yes, the user cannot f*ck them up so easily.

But he won't have something as a reference to make other scripts
(unless he'll go check the source...)

> They end up being parsed zero times.
>
> And running them twice looks like a bug in the design. I would not blame
> tokenization for design mistakes.

vlclua_scripts_batch_execute will run every file unless one return
success, so if there's both the script and the compiled version, both
will be tried...

> Packagers are not that stupid. automake only installs the tokenized version. I
> trust also Windows and MacOS packagers have enough clue not to ship both the
> tokenized and the source versions of each script.

Currently, we ship both, at least in windows nightlies...
And, if I'm not using a packed version but compiling, I'll have them
duplicated...



More information about the vlc-devel mailing list