[vlc-devel] [PATCH] Enable Lua SD loading with -S<name>

Fabio Ritrovato exsephiroth87 at gmail.com
Tue Feb 16 23:46:41 CET 2010


2010/2/16 Rémi Denis-Courmont <remi at remlab.net>:
> ...which s/he will do to get the 'readme' files anyway.

I think we should at least ship those...

> IOW, they only run once because the packager has a clue and did not install
> both tokenized and source version.
>
> From the build tree, .luac are not run anyhow as VLC scans
> $(top_srcdir)/share/lua/$role but not $(top_builddir)/share/lua/$role. First,
> I thought it was a bug. But it actually makes things easier for developers, so
> I decided to leave it unaddressed. The 5 developers (out of millions of users)
> running VLC from $(srcdir) can suffer duplicate entries; the sky won't fall
> for this.

Fair enough...

> Actually, we do not ship nightlies at all currently since the build broke
> before LUAC support was added.
>
> And we don't copy .luac files in most cases. In other cases, the problem would
> not exist if Windows used staged installation before packaging. But I gave up
> on this a long time ago. The Windows packagers have decided to keep their
> miserable system. I won't argue with this and I don't care anymore.

I'm pretty positive it was fixed, because i tested SDs on yesterday nightly...

Anyway, I see your points, now the issue is, how do we get the
longname out of the compiled script?
The only thing I can think of ATM would be to have a function in the
script that returns the string, but that would require to allocate the
lua structures and run every script during probing...



More information about the vlc-devel mailing list