[vlc-devel] [PATCH] MacOS GUI: Tie display fade to "Black out" preference

Ron Frederick ronf at timeheart.net
Fri Feb 19 06:20:17 CET 2010


Hello everyone!

I'm new to this list and new to attempting to make changes to VLC, so 
please bear with me if I don't quite get this right on my first try. I 
have a small patch that I'd like to submit to the list for 
consideration. It is for the MacOS GUI, and basically it fixes something 
that's bothered me for a while when running VLC on a system with 
multiple displays.

Basically, whenever VLC enters or leaves full-screen mode, it always 
causes all of the displays on the system (not just the one entering full 
screen) to fade down to black momentarily. There's a setting for when 
the displays other than the one playing the video will be blacked out 
during playback, and these displays will turn back on after the fade 
when that setting is disabled, but having these other displays fade to 
black both at the start and at the end of playback has never really made 
sense to me.

My patch causes the fading feature to be tied to whether VLC is set to 
black out these other displays or not. If it is, the fading will behave 
just as it does now. However, when this setting is disabled, the fade 
will no longer occur. The display going to full screen mode starts and 
stops playing the video as before but the other displays are not affected.

I've had some trouble the master branch of VLC to build from scratch, 
but I was able to test this patch against the 1.0.5 source built using 
MacPorts. I then took my change and migrated it into a copy of the 
master branch I had checked out, so it should be up to date with the 
latest committed code. I'd appreciate any feedback on this change, and 
would love it if someone could integrate it into the tree.

Thanks for listening!

-- 
Ron Frederick
ronf at timeheart.net

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-MacOS-GUI-Tie-display-fade-to-Black-out-preference.patch
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100218/e3a62448/attachment.ksh>


More information about the vlc-devel mailing list