[vlc-devel] [Patch] Correctly fill out input_item's es info, and slim down input_item_es_t.

[Pierre d'Herbemont]

Hey,

Please review the attached patch.

I consider it important because it properly fix libvlc_media_get_es(). We
are currently advising our poor user to create a new media_player with
--sout=#description which makes us look overcomplicated. Mostly because you
still have to attach an event and such to know when we are done, and also
because a full playback is launched, not saving CPU and memory.

Our alternative to this patch is to read the input_item's info dictionary.
And parse the string in it. Hence the modification stay in libvlc umbrella
and not in the core.

However I consider this patch as low risk:
- It is following how we fill the input_item's info which is an already
existing string dictionary.
- Its impact in term of performance is low. We are not using a full
es_format_t, but just a stripped down version of fixed size, which is what
we expose in libvlc_media.
- It's chirugical and circumvented.
- It's fixing a real issue in libvlc.

If it's not accepted I'll fix libvlc_media_get_es() in 1.1 by parsing
input_item's info field, which are correctly filled after preparsing for
most demuxer. I am ok with this, but wanted to get the patch archived on the
ML at least.

Thanks,

Pierre.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100222/5393aa56/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-input-Fill-in-the-input_item-es.patch
Type: application/octet-stream
Size: 3373 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100222/5393aa56/attachment.obj>