[vlc-devel] commit: Lua SD: let the user know we are working (Fabio Ritrovato )

[Pierre d'Herbemont]

On Mon, Feb 22, 2010 at 10:46 PM, git version control <git at videolan.org>wrote:

> vlc | branch: master | Fabio Ritrovato <sephiroth87 at videolan.org> | Mon
> Feb 22 22:41:57 2010 +0100| [d38329b4dbcc1901e2f3ac147e1dd0697a174a7e] |
> committer: Fabio Ritrovato
>
> Lua SD: let the user know we are working
>
> >
> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d38329b4dbcc1901e2f3ac147e1dd0697a174a7e
> ---
>
>  share/lua/sd/fmc.lua     |    2 ++
>  share/lua/sd/freebox.lua |    2 ++
>  share/lua/sd/icecast.lua |    2 ++
>  3 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/share/lua/sd/fmc.lua b/share/lua/sd/fmc.lua
> index 98ebf75..c1a9b3f 100644
> --- a/share/lua/sd/fmc.lua
> +++ b/share/lua/sd/fmc.lua
> @@ -26,6 +26,7 @@ function descriptor()
>  end
>
>  function main()
> +    local loading = vlc.sd.add_item( {path="vlc://nop",title="Loading..."}
> )
>

Even if the end result is nice in some context. It's not very generic. (read
it's very bad in Lunettes ;-) where we use some trick to hide empty SD, or
would prefer a spinning indicator).

The way to properly to it in Qt is to watch for
the vlc_ServicesDiscoveryStarted and vlc_ServicesDiscoveryEnded event. At
least it used to work that way. If it is not you should look forward adding
a new infrastructure for such event and let the client handle it.

I was displaying a spinning indicator in libvlc test prog using the
corresponding libvlc's event. And this was working great some time ago. I
don't think this was broken.

Pierre.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100223/b8ea44e9/attachment.html>