[vlc-devel] commit: playlist: consistently change input item type when subitems are added (Jakob Leben )

[Pierre d'Herbemont]

On Tue, Feb 23, 2010 at 12:44 PM, git version control <git at videolan.org>wrote:

> vlc | branch: master | Jakob Leben <jleben at videolan.org> | Tue Feb 23
> 12:39:41 2010 +0100| [abc84401cd082ccd70a8bb07f9d96c3cff12b122] | committer:
> Jakob Leben
>
> playlist: consistently change input item type when subitems are added
>
> >
> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=abc84401cd082ccd70a8bb07f9d96c3cff12b122
> ---
>
>  src/input/item.c    |    4 ----
>  src/playlist/item.c |   12 ++++++++++--
>  2 files changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/src/input/item.c b/src/input/item.c
> index 9872e99..416ec19 100644
> --- a/src/input/item.c
> +++ b/src/input/item.c
> @@ -254,10 +254,6 @@ static void post_subitems( input_item_node_t *p_node )
>  * the input item children. */
>  void input_item_PostSubItem( input_item_t *p_parent, input_item_t *p_child
> )
>  {
> -    vlc_mutex_lock( &p_parent->lock );
> -    p_parent->i_type = ITEM_TYPE_PLAYLIST;
> -    vlc_mutex_unlock( &p_parent->lock );


In the case of libvlc where the playlist don't work this won't work anymore.
What do you think about having it at both places?

Pierre.

>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100223/8325fb93/attachment.html>