[vlc-devel] commit: variables: print a warning if doing var_Set on a void variable. ( Rémi Duraffort )

git version control git at videolan.org
Tue Feb 23 22:12:31 CET 2010


vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Sun Feb 21 20:21:33 2010 +0100| [53e51f041445f19a53b82bc702c7ac9b97863350] | committer: Rémi Duraffort 

variables: print a warning if doing var_Set on a void variable.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=53e51f041445f19a53b82bc702c7ac9b97863350
---

 src/misc/variables.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/src/misc/variables.c b/src/misc/variables.c
index 9ac58dd..9df5a40 100644
--- a/src/misc/variables.c
+++ b/src/misc/variables.c
@@ -762,6 +762,12 @@ int var_SetChecked( vlc_object_t *p_this, const char *psz_name,
 
     assert( expected_type == 0 ||
             (p_var->i_type & VLC_VAR_CLASS) == expected_type );
+#ifndef NDEBUG
+        /* Alert if the type is VLC_VAR_VOID */
+        if( ( p_var->i_type & VLC_VAR_TYPE ) == VLC_VAR_VOID )
+            msg_Warn( p_this, "Calling var_Set on the void variable '%s' (0x%04x)", psz_name, p_var->i_type );
+#endif
+
 
     WaitUnused( p_this, p_var );
 
@@ -825,7 +831,7 @@ int var_GetChecked( vlc_object_t *p_this, const char *psz_name,
 #ifndef NDEBUG
         /* Alert if the type is VLC_VAR_VOID */
         if( ( p_var->i_type & VLC_VAR_TYPE ) == VLC_VAR_VOID )
-            msg_Warn( p_this, "Calling var_GetVoid on the void variable '%s' (0x%04x)", psz_name, p_var->i_type );
+            msg_Warn( p_this, "Calling var_Get on the void variable '%s' (0x%04x)", psz_name, p_var->i_type );
 #endif
 
         /* Duplicate value if needed */




More information about the vlc-devel mailing list