[vlc-devel] commit: sd: Make most members private. (Pierre d'Herbemont )

[Pierre d'Herbemont]

On Wed, Feb 24, 2010 at 2:03 PM, Fabio Ritrovato <exsephiroth87 at gmail.com>wrote:

> 2010/2/24 Rémi Denis-Courmont <remi at remlab.net>:
> >
> > On Wed, 24 Feb 2010 13:46:39 +0100 (CET), git at videolan.org (git version
> > control) wrote:
> >> vlc | branch: master | Pierre d'Herbemont <pdherbemont at free.fr> | Wed
> Feb
> >> 24 11:19:38 2010 +0100| [786292c3f205f96b467321c9973a2ba13029fb60] |
> >> committer: Pierre d'Herbemont
> >>
> >> sd: Make most members private.
> >
> > First, this sucks. The whole point of a configuration chain is to be
> > visible to plugins. Second, this is not the sort of change I'd expect in
> > the freeze period - it does not fix anything.
>
> I have not tested it but I think this will break Lua SD, it need to
> access the configuration chain, and now it won't find it...


Should be fixed along with a leak.

Pierre.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100224/93cb3087/attachment.html>