[vlc-devel] commit: Remove error/warnings from module_need() ( Rémi Denis-Courmont )

[git version control]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Thu Feb 25 23:56:45 2010 +0200| [ca6b633e9b398864ad0e4b6f125c7e30c3bf0221] | committer: Rémi Denis-Courmont 

Remove error/warnings from module_need()

They caused much confusion from bug reporters and support requestors.
Feel free to add more explicit and specific errors after module_need()
call sites in failure cases.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ca6b633e9b398864ad0e4b6f125c7e30c3bf0221
---

 src/modules/modules.c |   25 +++----------------------
 1 files changed, 3 insertions(+), 22 deletions(-)

diff --git a/src/modules/modules.c b/src/modules/modules.c
index a1eba6b..894168f 100644
--- a/src/modules/modules.c
+++ b/src/modules/modules.c
@@ -590,30 +590,11 @@ found_shortcut:
                                                : p_module->psz_object_name );
     }
     else if( count == 0 )
-    {
-        if( !strcmp( psz_capability, "access_demux" )
-         || !strcmp( psz_capability, "stream_filter" )
-         || !strcmp( psz_capability, "vout_window" ) )
-        {
-            msg_Dbg( p_this, "no %s module matched \"%s\"",
-                psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
-        }
-        else
-        {
-            msg_Err( p_this, "no %s module matched \"%s\"",
-                 psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
-
-            msg_StackSet( VLC_EGENERIC, "no %s module matched \"%s\"",
+        msg_Dbg( p_this, "no %s module matched \"%s\"",
                  psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
-        }
-    }
-    else if( psz_name != NULL && *psz_name )
-    {
-        msg_Warn( p_this, "no %s module matching \"%s\" could be loaded",
-                  psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
-    }
     else
-        msg_StackSet( VLC_EGENERIC, "no suitable %s module", psz_capability );
+        msg_Dbg( p_this, "no %s module matching \"%s\" could be loaded",
+                  psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
 
     free( psz_shortcuts );
     free( psz_var );