[vlc-devel] [PATCH] removed some signedness warnings

[Toralf Niebuhr]

Am 27.02.2010 um 21:10 schrieb Laurent Aimar:

> Hi,
> 
> On Sat, Feb 27, 2010, Toralf Niebuhr wrote:
>> removed some signedness warnings
>> 
>> one question:
>> include/vlc_picture.h
>> I'm not sure if the attribute i_pixel_pitch from struct plane_t should be size_t instead of unsigned int.
> I am not sure it would be wise to apply your patch so near 1.1, as
> moving from signed to unsigned may have unseen consequences.
> 
> About, i_pitch, I am unsure if it can be changed to unsigned, in some place
> it could be possible that a negative pitch is used for bottom to top image (At
> least it should be checked).
You are probably right about i_pixel_pitch.
All the other variables indicate some kind of size ( length for example ) so unsigned should be the right thing.
If there is no strange OS specific thing happening it should be ok to change the type.
On the other hand, if there are still casts going on they just happen in a different place.
> 
> Regards,
> 
> -- 
> fenrir
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel