[vlc-devel] commit: Qt4: passing pointers over thread signals is not allowed... ( Rémi Denis-Courmont )

[git version control]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun Feb 28 21:35:45 2010 +0200| [dcd592840d22bc93d287c9edbba72625746d1096] | committer: Rémi Denis-Courmont 

Qt4: passing pointers over thread signals is not allowed...

...unless proper reference counting si involved,
or the signal is blocking queued (but that is deadlock-prone).

Ref: LP#528285

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=dcd592840d22bc93d287c9edbba72625746d1096
---

 modules/gui/qt4/components/info_panels.cpp |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/modules/gui/qt4/components/info_panels.cpp b/modules/gui/qt4/components/info_panels.cpp
index c10cadd..a0fbb59 100644
--- a/modules/gui/qt4/components/info_panels.cpp
+++ b/modules/gui/qt4/components/info_panels.cpp
@@ -162,6 +162,8 @@ MetaPanel::MetaPanel( QWidget *parent,
  **/
 void MetaPanel::update( input_item_t *p_item )
 {
+#warning This is wrong.
+#if 0
     if( !p_item )
     {
         clear();
@@ -243,7 +245,7 @@ void MetaPanel::update( input_item_t *p_item )
     }
 
     art_cover->showArtUpdate( file );
-
+#endif
 }
 
 /**