[vlc-devel] commit: skins2: improve the way skins are listed (Erwan Tulou )
Rémi Duraffort
ivoire at videolan.org
Tue Jan 5 22:45:37 CET 2010
> + // retrieve skins for skins directories and locate default skins
> + map<string,string>::const_iterator itmap, itdefault;
> + for( itmap = m_skinsMap.begin(); itmap != m_skinsMap.end(); itmap++ )
> + {
> + string path = itmap->first;
> + string name = itmap->second;
> + val.psz_string = strdup( path.c_str() );
> + text.psz_string = strdup( name.c_str() );
Is it really neede to strdup the string ? AFAIK var_Change strdup the
string anyway !
> + var_Change( getIntf(), "intf-skins", VLC_VAR_ADDCHOICE, &val,
> + &text );
> + free( val.psz_string );
> + free( text.psz_string );
--
Rémi Duraffort | ivoire
More information about the vlc-devel
mailing list