[vlc-devel] commit: skins2: remove dead code (Erwan Tulou )

git version control git at videolan.org
Thu Jan 14 15:21:56 CET 2010


vlc | branch: master | Erwan Tulou <erwan10 at videolan.org> | Wed Jan 13 10:57:36 2010 +0100| [c0550de80f32a79842942c924290a9670f12628c] | committer: Erwan Tulou 

skins2: remove dead code

intf-change for playlist is never updated

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=c0550de80f32a79842942c924290a9670f12628c
---

 modules/gui/skins2/src/vlcproc.cpp |   26 --------------------------
 modules/gui/skins2/src/vlcproc.hpp |    5 -----
 2 files changed, 0 insertions(+), 31 deletions(-)

diff --git a/modules/gui/skins2/src/vlcproc.cpp b/modules/gui/skins2/src/vlcproc.cpp
index 0ebde91..38fa44d 100644
--- a/modules/gui/skins2/src/vlcproc.cpp
+++ b/modules/gui/skins2/src/vlcproc.cpp
@@ -158,9 +158,6 @@ VlcProc::VlcProc( intf_thread_t *pIntf ): SkinObject( pIntf ),
 
 #undef ADD_CALLBACK
 
-    // Called when the playlist changes
-    var_AddCallback( pIntf->p_sys->p_playlist, "intf-change",
-                     onIntfChange, this );
     // Called when a playlist item is added
     var_AddCallback( pIntf->p_sys->p_playlist, "playlist-item-append",
                      onItemAppend, this );
@@ -219,8 +216,6 @@ VlcProc::~VlcProc()
     var_DelCallback( getIntf()->p_sys->p_playlist, "repeat",
                      onGenericCallback, this );
 
-    var_DelCallback( getIntf()->p_sys->p_playlist, "intf-change",
-                     onIntfChange, this );
     var_DelCallback( getIntf()->p_sys->p_playlist, "playlist-item-append",
                      onItemAppend, this );
     var_DelCallback( getIntf()->p_sys->p_playlist, "playlist-item-deleted",
@@ -255,27 +250,6 @@ void VlcProc::CmdManage::execute()
 }
 
 
-int VlcProc::onIntfChange( vlc_object_t *pObj, const char *pVariable,
-                           vlc_value_t oldVal, vlc_value_t newVal,
-                           void *pParam )
-{
-    VlcProc *pThis = (VlcProc*)pParam;
-
-    // Update the stream variable
-    pThis->updateStreamName();
-
-    // Create a playtree notify command (for new style playtree)
-    CmdPlaytreeChanged *pCmdTree = new CmdPlaytreeChanged( pThis->getIntf() );
-
-    // Push the command in the asynchronous command queue
-    AsyncQueue *pQueue = AsyncQueue::instance( pThis->getIntf() );
-    pQueue->push( CmdGenericPtr( pCmdTree ) );
-
-    return VLC_SUCCESS;
-}
-
-
-
 int VlcProc::onInputNew( vlc_object_t *pObj, const char *pVariable,
                          vlc_value_t oldval, vlc_value_t newval, void *pParam )
 {
diff --git a/modules/gui/skins2/src/vlcproc.hpp b/modules/gui/skins2/src/vlcproc.hpp
index c558bb9..c38ff48 100644
--- a/modules/gui/skins2/src/vlcproc.hpp
+++ b/modules/gui/skins2/src/vlcproc.hpp
@@ -180,11 +180,6 @@ private:
     /// Update the stream name variable
     void updateStreamName();
 
-    /// Callback for intf-change variable
-    static int onIntfChange( vlc_object_t *pObj, const char *pVariable,
-                             vlc_value_t oldVal, vlc_value_t newVal,
-                             void *pParam );
-
     /// Callback for intf-show variable
     static int onIntfShow( vlc_object_t *pObj, const char *pVariable,
                            vlc_value_t oldVal, vlc_value_t newVal,




More information about the vlc-devel mailing list