[vlc-devel] [PATCH] GSoC: lua services discovery, final?

[Rémi Denis-Courmont]

Le dimanche 17 janvier 2010 20:08:44 Fabio Ritrovato, vous avez écrit :
> 2010/1/17 Rémi Denis-Courmont <remi at remlab.net>:
> > Antoine can correct me, but I thought a configuration chain was supposed
> > to be used to pass parameters to SD plugins.
> 
> It can be used, but we'd lose the ability to use -S from the command
> line,

--sout has been using a configuration chain since its inception. Now filters 
do the same. Are you claiming that --sout does not work? I'm lost.

> and we would need to change the way SD are activated in the
> interfaces...

Interfaces are using whatever string is fed to them by the probe service. I 
have not tested with a configuration chain (obviously), but I see no reasons 
why it wouldn't work, so long as the probe sub-module formats the string 
right.

> > It looks like it will fail on platforms with a non-UTF-8 file system.
> >
> > Are you sure vlc_cancel() actually works with the LUA interpreter?
> 
> I don't have a non-UTF-8 file system at hand to test, but which part
> are you referring to?

Anything that uses file paths.

> vlc_cancel() should work, it's used in the lua interface too,

I've heard that one before with Qt4. This may well be a grave bug in the LUA 
interface code.

> but just to be sure, how do i test that?

Testing that would be quite involved to say the least. It's best to check if 
the LUA interpreter, *and* the VLC callbacks into the LUA interpreter support 
it. But even that would be tedious given the amount of code. So that leaves 
you with the simplest and safest option: not to use vlc_cancel().

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis