[vlc-devel] [PATCH] GSoC: lua services discovery, final?

[Rémi Denis-Courmont]

Le dimanche 17 janvier 2010 22:00:25 Fabio Ritrovato, vous avez écrit :
> 2010/1/17 Rémi Denis-Courmont <remi at remlab.net>:
> > --sout has been using a configuration chain since its inception. Now
> > filters do the same. Are you claiming that --sout does not work? I'm
> > lost.
> 
> What I'm saying is that instead of using -S shoutcast, you will have
> to use -S lua --lua-sd shoutcast, a little less intuitive...

So "we'd lose the ability to use -S from the command line", or it would merely 
be "a little less intuitive" ? Now I am even more confused.

Do we really expect people to start LUA SD scripts from the command line? 
AFAICT, service discovery plugins are useless without the user interface (to 
show the result and select items).

> > Interfaces are using whatever string is fed to them by the probe service.
> > I have not tested with a configuration chain (obviously), but I see no
> > reasons why it wouldn't work, so long as the probe sub-module formats the
> > string right.
> 
> We still need to have 3 strings, and the current probe functions only
> handle 2...

We need the human visible name (already there), and the config chain (instead 
of the current module alias), which does include a plugin as the leading 
keyword, e.g.: 'luasd{script=shoutcast}'. And then we don't need to break the 
API everytime someone comes up with a new parameter.
 
> > Anything that uses file paths.
> 
> Is vlclua_scripts_batch_execute() in modules/misc/lua/vlc.c UTF-8 safe?

Looks so.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis