[vlc-devel] [PATCH] dummy vout: check for sys->pool before deleting it.

Ramiro Polla ramiro.polla at gmail.com
Mon Jan 18 19:16:12 CET 2010


I believe a similar check may be needed in modules/video_output/vmem.c
and modules/video_output/snapshot.c, but I haven't checked in depth
and it might be that if the pool is not created, Open() fails and so
there's no call to delete it (just guessing).

There's also something weird about this code in modules/video_output/vmem.c:
    /* */
    picture_pool_configuration_t pool;
    memset(&pool, 0, sizeof(pool));
    pool.picture_count = 1;
    pool.picture       = &picture;
    pool.lock          = Lock;
    pool.unlock        = Unlock;
    sys->pool = picture_pool_NewExtended(&pool);
    if (!sys->pool) {
        return VLC_SUCCESS;

Shouldn't it return VLC_EGENERIC?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dummy-vout-check-for-sys-pool-before-deleting-it.patch
Type: text/x-diff
Size: 759 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100118/c8774e37/attachment.patch>

More information about the vlc-devel mailing list