[vlc-devel] commit: autoconf: Don't hardcode shell in templates (Francois Cartegnie )

[Måns Rullgård]

git at videolan.org (git version control) writes:

> vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Sun Jan 17 18:50:36 2010 +0100| [0a0db525cf8fe71f395b178cfbb20e3ec92fde74] | committer: Rémi Denis-Courmont 
>
> autoconf: Don't hardcode shell in templates
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0a0db525cf8fe71f395b178cfbb20e3ec92fde74
> ---
>
>  configure.ac     |    5 ++++-
>  vlc-config.in.in |    2 +-
>  2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 753e21d..c27d7d7 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -5090,7 +5090,10 @@ dnl Do we have to use make or gmake ?
>  USE_MAKE_OR_GMAKE=`case "${SYS}" in openbsd*) echo "gmake";; *) echo "make";; esac`
>  dnl Shortcut to nice compile message
>  rm -f compile
> -echo '#! /bin/sh' >compile
> +if test -n $SHELL; then
> +  SHELL=${CONFIG_SHELL-/bin/sh}
> +fi
> +echo '#! '$SHELL >compile

$SHELL is typically the user's login shell.  If that is something like
tcsh (yes, such people exist), this will break horribly.

-- 
Måns Rullgård
mans at mansr.com