[vlc-devel] Fixed TCP handle leak on failed attempt to open network stream

[Rémi Denis-Courmont]

Le mercredi 20 janvier 2010 17:14:23 tom245292 at hushmail.me, vous avez écrit :
> Thanks. You were right about the problem being in
> src/misc/objects.c . I believe that the leak was actually caused by
> the position of the WIN32 specific winsock code (pipe() + def
> statements) that was located BELOW vlc_object_destroy(). These
> defined the close() statement as clocksocket() for WIN32. However,
> because they are defined AFTER vlc_object_destroy(), the close()
> statements have a different meaning inside vlc_object_destroy()
> itself. Consequently closesocket() doesn't get called and the two
> pipe sockets get left open.

Yes, that's correct. It should be fixed now.

Thanks for the investigation.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis