[vlc-devel] [PATCH] GSoC: lua services discovery, final?

[Fabio Ritrovato]

2010/1/21 Rémi Denis-Courmont <remi at remlab.net>:
> If it's true, then that logic is broken in any case. It's broken if you use
> a script name. It's broken if you use a SD plugin written with native C
> code (as currently). To my knowledge, you can't make assumptions about the
> uniqueness of a playlist item name.
>
> I write "If it's true", because I have no clue what you are referring to.
> playlist_ServicesDiscoveryAdd() compares the requested SD string against
> the list of strings of already loaded SD objects. I fail to see any problem
> with that. As far as I know, the same logic is used by --sout-keep and
> works just fine with configuration chains.

Actually,  playlist_ServicesDiscoveryAdd() doesn't check anything, it
just creates the new nodes anyway.
What check the list of loaded SD is
playlist_IsServicesDiscoveryLoaded(), that's called before Add...
The problem is that, the first SD is created fine, but when you want
to start a second one, playlist_IsServicesDiscoveryLoaded() will
return that it's already running (due to both havin the same name),
and so the new one will not start.